feat(android): Add M.2 WiFi/Bluetooth Module Setup application note #612
Conversation
glaroque
requested review from
StaticRocket,
VeeruPrudhvi,
cshilwant,
gehariprasath,
jeevantelukula,
praneethbajjuri and
uditkumarti
as code owners
|
New warnings found with rstcheck: |
glaroque
force-pushed
the
master
branch
2 times, most recently
from
321540f to
9df438e
Compare
StaticRocket
left a comment
StaticRocket
left a comment
There was a problem hiding this comment.
I like this, but vale has some comments about simple language that I think should be addressed
| Modify the following files to enable Bluetooth. | ||
|
|
||
|
|
||
| Modifying shared/bluetooth/device_vendor.mk |
There was a problem hiding this comment.
May want to shorten this to just
| Modifying shared/bluetooth/device_vendor.mk | |
| Modifying device_vendor.mk |
Makes the link and title a little more approachable, and it has less of a chance to change arbitrarily now
There was a problem hiding this comment.
device_vendor .mk can be found in multiple subfolder so will be not clear for user , look more logic for me to give good path directly
There was a problem hiding this comment.
Going to assume you meant that it would be more logical to give a direct path to the file. Fair enough, if that is not a unique tail. My only counter argument is that you give the exact path again in the paragraph directly below it.
I care about this far less than the vale comments currently. Those still need to be addressed...
glaroque
force-pushed
the
master
branch
2 times, most recently
from
9ee34b5 to
b68bb79
Compare
Add a new application note documenting the Android build system modifications required to integrate third-party M.2 Wi-Fi/Bluetooth modules on AM62Px-SK and AM62x-SK EVMs. The guide covers: - Wi-Fi firmware setup (Android.bp, product makefile) - Bluetooth configuration (HAL, permissions, properties) - SELinux policy for UART access - ueventd permissions Signed-off-by: Guillaume La Roque <[email protected]>
Signed-off-by: Guillaume La Roque <[email protected]>
StaticRocket
left a comment
StaticRocket
left a comment
There was a problem hiding this comment.
Otherwise this seems fine. The mixed use of inline code for file names in the section titles messes with me, but I don't think it's a deal-breaker.
| SDIO | ||
| UART |
There was a problem hiding this comment.
Acronyms should not be added to the dictionary, as they are not words themselves.
| ###################################### | ||
| M.2 Wi-Fi and Bluetooth module setup | ||
| ###################################### |
| ********************* | ||
| Wi-Fi firmware setup | ||
| ********************* |
4 participants
Add a new application note documenting the Android build system modifications required to integrate third-party M.2 WiFi/Bluetooth modules on AM62Px-SK and AM62x-SK EVMs.
The guide covers: